Add support for Oracle database plugin connection options #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dheeg
force-pushed
the
feature/oracle_plugin_connect_options
branch
from
ddfabaf to
77806d7
Compare
|
@fairclothjm Sorry for pinging directly. Is there a chance to get a review for this PR? |
fairclothjm
reviewed
Jan 22, 2024
There was a problem hiding this comment.
@dheeg Hello, thanks for the contribution! Sorry for the delay. Could you rebase your changes on the main branch? Thanks!
fairclothjm
reviewed
Feb 2, 2024
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ FEATURES: | |||
| FEATURES: | |||
| * Add support for `ext_key_usage_oids` in `vault_pki_secret_backend_role` ([#2108](https://github.com/hashicorp/terraform-provider-vault/pull/2108)) | |||
| * Adds support to `vault_gcp_auth_backend` for common backend tune parameters ([#1997](https://github.com/terraform-providers/terraform-provider-vault/pull/1997)). | |||
| * Add support for Oracle database plugin configuration options `split_statements` and `disconnect_sessions`: ([#2085](https://github.com/hashicorp/terraform-provider-vault/pull/2085)) | |||
There was a problem hiding this comment.
This should go under the Unreleased section.
There was a problem hiding this comment.
@fairclothjm done, moved the changelog entry
Move changelog entry to unreleased section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 2021 the Oracle database plugin for Vault introduced new configuration options as described here: hashicorp/vault-plugin-database-oracle#62
This PR exposes those database connection options, which are especially important for Oracle AWS RDS installations, as those don't support the default plugin revocation statements see: hashicorp/vault-plugin-database-oracle#45
I personally don't expect that this PR will receive a lot of upvotes, because it's a niche scenario => Oracle on AWS + Vault + Terraform to provision Vault. However it might be important for a few enterprises (including us).
Checklist
Output from acceptance testing:
Community Note