Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iam_tags to vault_aws_secret_backend_role #2231

Merged
merged 4 commits into from
May 1, 2024

Conversation

thyton
Copy link
Contributor

@thyton thyton commented Apr 30, 2024

Description

This PR adds iam_tags to vault_aws_secret_backend_role resource, picking up the remaining work on #2087

Closes #1073

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

~/go/src/github.com/hashicorp/terraform-provider-vault (add-iam-tags-to-aws-secret-backend) $ make testacc TESTARGS='-run=TestAccAWSSecretBackendRole'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -run=TestAccAWSSecretBackendRole -timeout 30m ./...
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/helper	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/consts	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/codegen	0.402s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/group	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/mfa	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/pki	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/sync	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/util/mountutil	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/identity/entity	0.584s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/internal/provider	0.814s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/testutil	1.059s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/util	1.256s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/vault	0.766s

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@thyton thyton marked this pull request as draft April 30, 2024 19:04
@thyton thyton marked this pull request as ready for review May 1, 2024 06:11
@thyton thyton requested a review from a team May 1, 2024 15:23
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests and TF scripts work as expected. Thanks for adding support for this :)

@vinay-gopalan vinay-gopalan added this to the 4.3.0 milestone May 1, 2024
@thyton
Copy link
Contributor Author

thyton commented May 1, 2024

Thank you!

@benashz benashz requested review from benashz and removed request for benashz May 1, 2024 21:13
@thyton thyton merged commit f9a2344 into main May 1, 2024
13 checks passed
@thyton thyton deleted the add-iam-tags-to-aws-secret-backend branch May 1, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault_aws_secret_backend_role doesn't support specifying iam_tags
3 participants