Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the bound_claims_type attribute in the JWT auth #877

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Add support for the bound_claims_type attribute in the JWT auth #877

merged 4 commits into from
Dec 9, 2020

Conversation

maxenced
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #700
Relates #752 - Based on #752 , only fix tests.

Release note for CHANGELOG:

Added support for using globs in matching bound_claims for the jwt_auth_backend_role

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccJWTAuthBackendRole'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccJWTAuthBackendRole -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault[no test files]
?   	github.com/terraform-providers/terraform-provider-vault/cmd/coverage	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	(cached) [no tests to run]
=== RUN   TestAccJWTAuthBackendRole_import
--- PASS: TestAccJWTAuthBackendRole_import (0.29s)
=== RUN   TestAccJWTAuthBackendRole_basic
--- PASS: TestAccJWTAuthBackendRole_basic (0.23s)
=== RUN   TestAccJWTAuthBackendRole_update
--- PASS: TestAccJWTAuthBackendRole_update (0.39s)
=== RUN   TestAccJWTAuthBackendRole_full
--- PASS: TestAccJWTAuthBackendRole_full (0.24s)
=== RUN   TestAccJWTAuthBackendRoleOIDC_full
--- PASS: TestAccJWTAuthBackendRoleOIDC_full (1.08s)
=== RUN   TestAccJWTAuthBackendRole_fullUpdate
--- PASS: TestAccJWTAuthBackendRole_fullUpdate (0.39s)
=== RUN   TestAccJWTAuthBackendRole_fullDeprecated
--- PASS: TestAccJWTAuthBackendRole_fullDeprecated (0.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault	3.036s
...

@maxenced maxenced mentioned this pull request Oct 14, 2020
Closed
@maxenced
Copy link
Contributor Author

@kalafut anyting I can do to get this merged ?

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hammopau
Copy link

hammopau commented Dec 3, 2020 •
edited
Loading

Any update on release of this? We really need it now.
@kalafut

@tvoran tvoran self-requested a review December 7, 2020 16:23
@tvoran tvoran added this to the Future milestone Dec 7, 2020
tvoran
tvoran requested changes Dec 7, 2020
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! See below for some suggestions.

vault/resource_jwt_auth_backend_role.go Outdated Show resolved Hide resolved
vault/resource_jwt_auth_backend_role_test.go Outdated Show resolved Hide resolved
vault/resource_jwt_auth_backend_role_test.go Outdated Show resolved Hide resolved
website/docs/r/jwt_auth_backend_role.html.md Outdated Show resolved Hide resolved
vault/resource_jwt_auth_backend_role_test.go Outdated Show resolved Hide resolved
vault/resource_jwt_auth_backend_role_test.go Outdated Show resolved Hide resolved
vault/resource_jwt_auth_backend_role_test.go Outdated Show resolved Hide resolved
@maxenced @tvoran
Make bound_claims_type computed value
2d582a9 
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@maxenced maxenced requested a review from tvoran December 9, 2020 13:55
@maxenced
Copy link
Contributor Author

maxenced commented Dec 9, 2020

have added your suggestions

@tvoran tvoran modified the milestones: Future, vNext Dec 9, 2020
tvoran
tvoran approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again! We'll get this out in the next release.

@tvoran tvoran merged commit 6542620 into hashicorp:master Dec 9, 2020
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@maxenced @randomswdev
Add support for the bound_claims_type attribute in the JWT auth (has…
0b91136 
…hicorp#877)

* Add support for the bound_claims_type attribute in the JWT auth

* Code review change

* make test pass with bound_claims_type attribute

* Make bound_claims_type computed value

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Co-authored-by: Bernardo Pastorelli <berpast@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran approved these changes

Assignees
No one assigned
Labels
documentation size/S
Projects
None yet
Milestone
vNext
Development

Successfully merging this pull request may close these issues.

Add support for for the bound_claims_type attribute in the JWT auth (Vault 1.4.0)
5 participants
@maxenced @hashicorp-cla @hammopau @tvoran @randomswdev