Extend earlydecoder to decode module calls #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow decoding modules blocks and their source and version attributes
This adds moduleCalls as a new field to Meta and extends the decoder to return the decoded module calls.
radeksimko
approved these changes
May 3, 2022
| @@ -23,6 +23,7 @@ type decodedModule struct { | |||
| DataSources map[string]*dataSource | |||
| Variables map[string]*module.Variable | |||
| Outputs map[string]*module.Output | |||
| ModuleCalls map[string]*module.ModuleCall | |||
There was a problem hiding this comment.
map is a reasonable structure for hashicorp/terraform-ls#598 and hashicorp/terraform-ls#725 but I'm guessing that unnamed modules may also be helpful to parse in the context of hashicorp/terraform-ls#869 - so we might end up turning this map into slice.
One could make the same argument about entries within the required_providers block. 🤔
Something we can revisit later...
This was referenced May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the first part of hashicorp/terraform-ls#882 and extends the earlydecoder to decode module calls inside a Terraform file.
Decoded module calls are stored in
module.Metafor consumption by terraform-ls.We're only decoding the
sourceandversionattribute of a module block and don't resolve/fill thePathattribute of aModuleCall.