Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: introduce lifecycle conditions #115

Merged
merged 2 commits into from
Jun 30, 2022
Merged

schema: introduce lifecycle conditions #115

merged 2 commits into from
Jun 30, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jun 20, 2022 •
edited
Loading

@radeksimko radeksimko force-pushed the f-lifecycle-conditions branch from 3c85d94 to f23e8e4 Compare June 20, 2022 13:23
@radeksimko radeksimko marked this pull request as ready for review June 20, 2022 19:20
@radeksimko radeksimko requested a review from a team June 20, 2022 19:21
@radeksimko radeksimko force-pushed the f-lifecycle-conditions branch from f23e8e4 to 01dad3e Compare June 28, 2022 12:51
@radeksimko radeksimko mentioned this pull request Jun 28, 2022
Merged
dbanck
dbanck approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor suggestion:

Do we want to extend the core_schema_test with a test case for the new version?

terraform-schema/schema/core_schema_test.go

Lines 58 to 61 in 32428c4

testCases := []struct {
version *version.Version
matchedSchema versionedBodySchema
}{

@radeksimko radeksimko merged commit f96f94a into main Jun 30, 2022
@radeksimko radeksimko deleted the f-lifecycle-conditions branch June 30, 2022 14:23
@radeksimko radeksimko mentioned this pull request Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reflect preconditions & postconditions
2 participants
@radeksimko @dbanck