Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Fix schema merging for terraform_remote_state data source #272

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Oct 6, 2023

Originally reported in hashicorp/vscode-terraform#1575


When implementing the fix in #251 we forgot to account for other parts of the terraform_remote_state schema which come in the form of provider schema, namely workspace, defaults and outputs.

@radeksimko radeksimko added the bug Something isn't working label Oct 6, 2023
@radeksimko radeksimko self-assigned this Oct 6, 2023
@radeksimko radeksimko changed the title schema: Fix schema merging for terraform_remote_state data source schema: Fix schema merging for terraform_remote_state data source Oct 6, 2023
@radeksimko radeksimko force-pushed the b-fix-ds-remote-state-schema-merge branch from e7795ae to 318a0fe Compare October 6, 2023 10:20
@radeksimko radeksimko force-pushed the b-fix-ds-remote-state-schema-merge branch from 318a0fe to ab8a2ca Compare October 6, 2023 10:23
@radeksimko radeksimko marked this pull request as ready for review October 6, 2023 10:25
@radeksimko radeksimko requested a review from a team as a code owner October 6, 2023 10:25
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@radeksimko radeksimko merged commit 72331e9 into main Oct 6, 2023
5 checks passed
@radeksimko radeksimko deleted the b-fix-ds-remote-state-schema-merge branch October 6, 2023 12:31
@jsinme
Copy link

jsinme commented Oct 9, 2023

I'm having an issue where the syntax highlighter is complaining about the config block in the terraform_remote_state data source: Unexpected attribute: An attribute named "config" is not expected here
I reverted to v2.27.2 and the error went away so I believe there is still an issue with the schema here
I will attempt to take a look and contribute a fix, but this is my first interaction with this code base so someone else may be able to find and resolve this quicker

@radeksimko
Copy link
Member Author

@jsinme We are aware of this, it's a different bug which we're tracking in hashicorp/vscode-terraform#1580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants