Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conclude Terraform Experiments Completion #337

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Apr 1, 2024

This commit concludes the work on the Terraform experiments feature by removing the list of features from completion for the experiments attriubute.

Terraform language experiments are temporary features that are added, removed, and/or concluded at cadences too unpredictable to be included in this completion list. These are used in alpha or beta builds of Terraform and are changed frequently enough that it would either always be out of date or require constant releases to keep up to date.

As such, the completion list for the experiments attribute has been removed and documentation added to instruct the user to look to documentation for the particular release they are using for a list of features that can be enabled.

Closes #328

This commit concludes the work on the Terraform experiments feature by removing the list of features from completion for the `experiments` attriubute.

Terraform language experiments are temporary features that are added, removed, and/or concluded at cadences too unpredictable to be included in this completion list. These are used in alpha or beta builds of Terraform and are changed frequently enough that it would either always be out of date or require constant releases to keep up to date.

As such, the completion list for the `experiments` attribute has been removed and documentation added to instruct the user to look to documentation for the particular release they are using for a list of features that can be enabled.
@jpogran jpogran self-assigned this Apr 1, 2024
@jpogran jpogran marked this pull request as ready for review April 1, 2024 13:24
@jpogran jpogran requested a review from a team as a code owner April 1, 2024 13:24
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a typo

internal/schema/0.14/terraform.go Outdated Show resolved Hide resolved
@ansgarm ansgarm requested a review from dbanck April 10, 2024 08:12
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll create a follow up issue for the AnyKeyword expression

@dbanck dbanck merged commit 72025f5 into main Apr 10, 2024
5 checks passed
@dbanck dbanck deleted the conclude_tf_experiments_completion branch April 10, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema: Conclude module_variable_optional_attrs language experiment (v1.8)
4 participants