Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(TF-19384) Support locals in stack and deploy configs #395

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Aug 21, 2024

This change adds support for locals in stack and deployment configuration. This also adds minimal reference support for locals, allowing go to definition and find references to work for locals.

@jpogran jpogran self-assigned this Aug 21, 2024
@jpogran jpogran changed the base branch from main to pre-release August 21, 2024 17:11
@jpogran jpogran changed the title add locals stacks (TF-19384) Support locals in stack and deploy configs Aug 21, 2024
@jpogran jpogran marked this pull request as ready for review August 21, 2024 17:12
@jpogran jpogran requested a review from a team as a code owner August 21, 2024 17:12
This change adds support for locals in stack and deployment configuration. This also adds minimal reference support for locals, allowing go to definition and find references to work for locals.
@jpogran jpogran force-pushed the add_locals_stacks branch from 4cb5d85 to deb859c Compare August 21, 2024 17:24
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@ansgarm ansgarm merged commit 1800e4c into pre-release Aug 22, 2024
5 checks passed
@ansgarm ansgarm deleted the add_locals_stacks branch August 22, 2024 07:52
jpogran added a commit that referenced this pull request Aug 30, 2024
This change adds support for locals in stack and deployment configuration. This also adds minimal reference support for locals, allowing go to definition and find references to work for locals.
ansgarm pushed a commit that referenced this pull request Sep 23, 2024
This change adds support for locals in stack and deployment configuration. This also adds minimal reference support for locals, allowing go to definition and find references to work for locals.
ansgarm pushed a commit that referenced this pull request Sep 23, 2024
This change adds support for locals in stack and deployment configuration. This also adds minimal reference support for locals, allowing go to definition and find references to work for locals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants