schema: Account for short (Registry) module source address #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
commented
Feb 3, 2022
| @@ -51,7 +51,7 @@ func (m *SchemaMerger) SchemaForModule(meta *module.Meta) (*schema.BodySchema, e | |||
| return nil, coreSchemaRequiredErr{} | |||
| } | |||
|
|
|||
| if meta == nil || m.schemaReader == nil { | |||
| if meta == nil { | |||
There was a problem hiding this comment.
This just makes testing a bit easier as less tests require provider schema.
dbanck
approved these changes
Feb 8, 2022
| }, | ||
| } | ||
|
|
||
| depSchema, err := schemaForDependentModuleBlock(module.LocalName, modMeta) |
There was a problem hiding this comment.
Can we remove the schemaForDependentModuleBlock call here as we already fetched depSchema in line 209?
This was referenced Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch we'd expect all module manifest entries to match exactly with the
sourcevalue, which is true in most/all cases of local modules, but not in case of remote modules - esp. those in the TF Registry.manifest entries
{ "Modules": [ { "Key": "eks_cluster", "Source": "registry.terraform.io/terraform-aws-modules/eks/aws", "Version": "18.2.2", "Dir": ".terraform/modules/eks_cluster" } ] }corresponding config
This therefore enables completion, hover, go-to-definition/reference etc. when remote modules from the Registry are involved:
