provider/aws: set default SG description

because requiring a SG description is annoying
hashicorp · Apr 22, 2015 · 0798566 · 0798566
1 parent 92ebb60
commit 0798566
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/builtin/providers/aws/resource_aws_security_group.go b/builtin/providers/aws/resource_aws_security_group.go
@@ -31,7 +31,8 @@ func resourceAwsSecurityGroup() *schema.Resource {
 
  "description": &schema.Schema{
  Type: schema.TypeString,
- Required: true,
+ Optional: true,
+ Default: "Managed by Terraform",
  },
 
  "vpc_id": &schema.Schema{

diff --git a/builtin/providers/aws/resource_aws_security_group_test.go b/builtin/providers/aws/resource_aws_security_group_test.go
@@ -197,6 +197,8 @@ func TestAccAWSSecurityGroup_generatedName(t *testing.T) {
  Config: testAccAWSSecurityGroupConfig_generatedName,
  Check: resource.ComposeTestCheckFunc(
  testAccCheckAWSSecurityGroupExists("aws_security_group.web", &group),
+ resource.TestCheckResourceAttr(
+ "aws_security_group.web", "description", "Managed by Terraform"),
  func(s *terraform.State) error {
  if group.GroupName == nil {
  return fmt.Errorf("bad: No SG name")
@@ -549,8 +551,6 @@ resource "aws_security_group" "foo" {
 
 const testAccAWSSecurityGroupConfig_generatedName = `
 resource "aws_security_group" "web" {
- description = "Used in the terraform acceptance tests"
-
  ingress {
  protocol = "tcp"
  from_port = 80