don't apply unchanged attributes from legacy diffs

If a legacy diff has equal old and new values, don't apply the diff. These would show up in sets, because of the overall change in set key.
hashicorp · Nov 1, 2018 · 7e4f09c · 7e4f09c
1 parent e91f381
commit 7e4f09c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/terraform/diff.go b/terraform/diff.go
@@ -457,6 +457,11 @@ func (d *InstanceDiff) ApplyToValue(base cty.Value, schema *configschema.Block)
 			continue
 		}
 
+		// sometimes helper/schema gives us values that aren't really a diff
+		if diff.Old == diff.New {
+			continue
+		}
+
 		attrs[attr] = diff.New
 	}