command/jsonstate,plan: fix panic with null values (#23492)

The code responsible for marshalling attribute values was checking for nil values, but not null. Fixes #23485, #23274
hashicorp · Nov 25, 2019 · 99225b8 · 99225b8
1 parent 211cf08
commit 99225b8
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 2 deletions.
diff --git a/command/jsonplan/values.go b/command/jsonplan/values.go
@@ -26,7 +26,7 @@ type stateValues struct {
 type attributeValues map[string]interface{}
 
 func marshalAttributeValues(value cty.Value, schema *configschema.Block) attributeValues {
-	if value == cty.NilVal {
+	if value == cty.NilVal || value.IsNull() {
 		return nil
 	}
 	ret := make(attributeValues)

diff --git a/command/jsonplan/values_test.go b/command/jsonplan/values_test.go
@@ -30,6 +30,18 @@ func TestMarshalAttributeValues(t *testing.T) {
 			},
 			nil,
 		},
+		{
+			cty.NullVal(cty.String),
+			&configschema.Block{
+				Attributes: map[string]*configschema.Attribute{
+					"foo": {
+						Type:     cty.String,
+						Optional: true,
+					},
+				},
+			},
+			nil,
+		},
 		{
 			cty.ObjectVal(map[string]cty.Value{
 				"foo": cty.StringVal("bar"),

diff --git a/command/jsonstate/state.go b/command/jsonstate/state.go
@@ -101,9 +101,10 @@ type resource struct {
 type attributeValues map[string]interface{}
 
 func marshalAttributeValues(value cty.Value, schema *configschema.Block) attributeValues {
-	if value == cty.NilVal {
+	if value == cty.NilVal || value.IsNull() {
 		return nil
 	}
+
 	ret := make(attributeValues)
 
 	it := value.ElementIterator()

diff --git a/command/jsonstate/state_test.go b/command/jsonstate/state_test.go
@@ -91,6 +91,18 @@ func TestMarshalAttributeValues(t *testing.T) {
 			},
 			nil,
 		},
+		{
+			cty.NullVal(cty.String),
+			&configschema.Block{
+				Attributes: map[string]*configschema.Attribute{
+					"foo": {
+						Type:     cty.String,
+						Optional: true,
+					},
+				},
+			},
+			nil,
+		},
 		{
 			cty.ObjectVal(map[string]cty.Value{
 				"foo": cty.StringVal("bar"),