Add health_check to aws_elb resource #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also this can absolutely be switched to Update as well, just starting with the minimal approach |
|
|
||
| if _, ok := rs.Attributes["health_check.#"]; ok { | ||
| v := flatmap.Expand(rs.Attributes, "health_check").([]interface{}) | ||
| health_check := v[0].(map[string]interface{}) |
There was a problem hiding this comment.
Yea, right now with how we handle embedded objects, this is the best we can do. Extra health checks will just be ignored, which is fine.
|
Great! I'm going to merge this in and add an acceptance test case for it, which I'll cc you on. Thanks! |
pearkes
added a commit
that referenced
this pull request
Jul 30, 2014
Add health_check to aws_elb resource
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure I've done this right, but this IS working if you add mitchellh/goamz#71.
There can only be one health_check per ELB, but I can't work out how you can assert that there is only one, and that you don't need an array.
Also, I will probably need to rebase this PR if you merge #103 (add subnets and internal to the ELB resource), since it affects nearly the same lines.