Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subnets and internal to aws elb resource #103

Closed
wants to merge 3 commits into from
Closed

Add subnets and internal to aws elb resource #103

wants to merge 3 commits into from

Conversation

vertis
Copy link
Contributor

@vertis vertis commented Jul 30, 2014

No description provided.

@vertis
Copy link
Contributor Author

vertis commented Jul 30, 2014

@pearkes I've rebased now that #109 has been merged so this should merge cleanly

@pearkes
Copy link
Contributor

pearkes commented Jul 30, 2014

Hey @vertis, do you mind adding subnets to the update_state func? That will allow us to refresh and get any subnets we didn't explicitly add, among other things.

@vertis
Copy link
Contributor Author

vertis commented Jul 30, 2014

@pearkes sure :)

Learning Learning.

Subnets is not currently exposed in goamz's DescribeLoadBalancers. So I'll need to make another pull request on goamz...will do that when I get a moment.

@pearkes
Copy link
Contributor

pearkes commented Aug 7, 2014

Hey @vertis, how goes this? I can merge as is and finish it up, but if you plan to let me know.

@mitchellh
Copy link
Contributor

Closing due to lack of activity. But thanks for the contribution @vertis. Internal made it in from a more recent PR! :)

@mitchellh mitchellh closed this Sep 30, 2014
@ghost ghost locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants