Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Elastic File System DNS name has (silently?) changed #10902

Closed
aisamu opened this issue Dec 22, 2016 · 6 comments
Closed

AWS Elastic File System DNS name has (silently?) changed #10902

aisamu opened this issue Dec 22, 2016 · 6 comments

Comments

@aisamu
Copy link

aisamu commented Dec 22, 2016

Hi there!

It turns out, as per the AWS Console and new EC2 mounting instructions, AWS has (silently?) dropped the availability zone from the EFS DNS name.

The former us-east-1a.fs-xxxxxxxx.efs.us-east-1.amazonaws.com becomes just fs-xxxxxxxx.efs.us-east-1.amazonaws.com.

Unfortunately, aws_efs_mount_target.xxx.dns_name still outputs the old format.

For the moment, just dropping the AZ from the DNS works, as in replace(aws_efs_mount_target.xxx.dns_name, "/\\A[^\\.]*\\./", ""), but I figured it'd be useful to let you know!

Thanks a lot for this great tool!

Affected Resource(s)

  • aws_efs_file_system
@pdecat
Copy link
Contributor

pdecat commented Dec 27, 2016

FWIW, this change was discreetly announced last week https://aws.amazon.com/fr/about-aws/whats-new/2016/12/simplified-mounting-of-amazon-efs-file-systems/

@stack72
Copy link
Contributor

stack72 commented Jan 4, 2017

Hi @aisamu

thanks for the bug report here - can you tell me if terraform refresh updates the dns_name?

Thanks

Paul

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Jan 4, 2017
@aisamu
Copy link
Author

aisamu commented Jan 4, 2017

Hey!

Sadly, it doesn't =(

@stack72
Copy link
Contributor

stack72 commented Jan 4, 2017

Found the error! It will be fixed as of 0.8.3 :)

@stack72 stack72 removed the waiting-response An issue/pull request is waiting for a response from the community label Jan 4, 2017
@aisamu
Copy link
Author

aisamu commented Jan 4, 2017

Thanks for such awesome tool!

stack72 added a commit that referenced this issue Jan 4, 2017
Fixes:#10902

AWS introduced a change to the Mount Target DNS Name to remove the
availability_zone from it -
https://aws.amazon.com/about-aws/whats-new/2016/12/simplified-mounting-of-amazon-efs-file-systems/

This was because there used to be a limit of 1 mount target per AZ -
this has been raised.

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEFSMountTarget_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/04 10:45:35 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEFSMountTarget_ -timeout 120m
=== RUN   TestAccAWSEFSMountTarget_importBasic
--- PASS: TestAccAWSEFSMountTarget_importBasic (236.19s)
=== RUN   TestAccAWSEFSMountTarget_basic
--- PASS: TestAccAWSEFSMountTarget_basic (445.52s)
=== RUN   TestAccAWSEFSMountTarget_disappears
--- PASS: TestAccAWSEFSMountTarget_disappears (228.31s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	910.044s
```
stack72 added a commit that referenced this issue Jan 4, 2017
Fixes:#10902

AWS introduced a change to the Mount Target DNS Name to remove the
availability_zone from it -
https://aws.amazon.com/about-aws/whats-new/2016/12/simplified-mounting-of-amazon-efs-file-systems/

This was because there used to be a limit of 1 mount target per AZ -
this has been raised.

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEFSMountTarget_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/04 10:45:35 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEFSMountTarget_ -timeout 120m
=== RUN   TestAccAWSEFSMountTarget_importBasic
--- PASS: TestAccAWSEFSMountTarget_importBasic (236.19s)
=== RUN   TestAccAWSEFSMountTarget_basic
--- PASS: TestAccAWSEFSMountTarget_basic (445.52s)
=== RUN   TestAccAWSEFSMountTarget_disappears
--- PASS: TestAccAWSEFSMountTarget_disappears (228.31s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	910.044s
```
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants