Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SNS delivery status support #11739

Closed
pjungermann opened this issue Feb 7, 2017 · 2 comments
Closed

AWS SNS delivery status support #11739

pjungermann opened this issue Feb 7, 2017 · 2 comments

Comments

@pjungermann
Copy link

pjungermann commented Feb 7, 2017

Hej Terraform team,

It would be great to support the SNS delivery status logging. This was already asked for at issue #5386, but got closed due to inactivity.

You can find an example for how to enable it at the console and via the Java API at

I think it would fit either as a new attribute to the "aws_sns_topic" resource or maybe even better as a new:

resource "aws_sns_topic_delivery_status" "sqs_delivery_status" {
  topic_arn           = "${aws_sns_topic.my_sns_topic.arn}"
  endpoint            = "sqs" # application, http, lambda, sqs, * / all (default)
  success_sample_rate = 50 # default: 100
  success_role_arn    = "${aws_iam_role.cloud_watch_logging.arn}"
  failure_role_arn    = "${aws_iam_role.cloud_watch_logging.arn}"
}
@gazoakley
Copy link
Contributor

The list of topic attributes is here: http://docs.aws.amazon.com/sns/latest/dg/msg-status-topics.html#w1ab1c25c11b7

I'd add this as attributes to the existing aws_sns_topic resource, since you can only specify one success ARN/success sample rate/failure ARN for each type of endpoint. The mappings would be pretty similar to what the console lets you setup too:

Imgur

Maybe have new attributes on the SNS topic named:

  • application_success_feedback_role_arn
  • application_success_feedback_sample_rate
  • application_failure_feedback_role_arn
  • http_success_feedback_role_arn
  • http_success_feedback_sample_rate
  • http_failure_feedback_role_arn
  • lambda_success_feedback_role_arn
  • lambda_success_feedback_sample_rate
  • lambda_failure_feedback_role_arn
  • sqs_success_feedback_role_arn
  • sqs_success_feedback_sample_rate
  • sqs_failure_feedback_role_arn

@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants