Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SNS delivery status support #515

Closed
hashibot opened this issue Jun 13, 2017 · 7 comments
Closed

AWS SNS delivery status support #515

hashibot opened this issue Jun 13, 2017 · 7 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service.
Milestone

Comments

@hashibot
Copy link

This issue was originally opened by @pjungermann as hashicorp/terraform#11739. It was migrated here as part of the provider split. The original body of the issue is below.


Hej Terraform team,

It would be great to support the SNS delivery status logging. This was already asked for at issue hashicorp/terraform#5386, but got closed due to inactivity.

You can find an example for how to enable it at the console and via the Java API at

I think it would fit either as a new attribute to the "aws_sns_topic" resource or maybe even better as a new:

resource "aws_sns_topic_delivery_status" "sqs_delivery_status" {
  topic_arn           = "${aws_sns_topic.my_sns_topic.arn}"
  endpoint            = "sqs" # application, http, lambda, sqs, * / all (default)
  success_sample_rate = 50 # default: 100
  success_role_arn    = "${aws_iam_role.cloud_watch_logging.arn}"
  failure_role_arn    = "${aws_iam_role.cloud_watch_logging.arn}"
}
@hashibot hashibot added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 13, 2017
@StephenWithPH
Copy link

It appears this work is already done, but got lost in the repo splitting. See hashicorp/terraform#14101.

@gazoakley ... are you willing to port this over?

@gazoakley
Copy link
Contributor

@bflad bflad added the service/sns Issues and PRs that pertain to the sns service. label Jan 23, 2018
@bflad
Copy link
Contributor

bflad commented Feb 6, 2018

@gazoakley thanks so much for porting this over and helping direct everyone here 💯 I'll be reviewing #2872 shortly.

@bflad bflad added this to the v1.9.0 milestone Feb 6, 2018
@bflad
Copy link
Contributor

bflad commented Feb 6, 2018

The new attributes for aws_sns_topic to support delivery status have been merged into master in #2872 and will be released in v1.9.0 of the AWS provider, expected the end of this week. Happy Terraform'ing! 🎉

@bflad bflad closed this as completed Feb 6, 2018
@gazoakley
Copy link
Contributor

Thanks @bflad 👍

@bflad
Copy link
Contributor

bflad commented Feb 9, 2018

This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service.
Projects
None yet
Development

No branches or pull requests

4 participants