Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Mark password fields as sensitive #13147

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

radeksimko
Copy link
Member

Related to #13132 and #13145

These came up when I grepped through aws provider for password" and key".

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One question though, will this have any effect on people's state? I.e. will it trigger a diff?

@radeksimko
Copy link
Member Author

No, this won't trigger any diff because Sensitive doesn't affect state at all, it's purely a UI feature which affects whether or not is the attribute value displayed in plan or apply output.

@radeksimko radeksimko merged commit 5db819d into master Mar 29, 2017
@radeksimko radeksimko deleted the f-aws-sensitive-fields branch March 29, 2017 10:15
@dougneal
Copy link
Contributor

@radeksimko @stack72 in relation to directory services passwords would you consider merging #9848 as an additional measure? As far as I can tell there is no use of storing the password unhashed once it's been set initially!

@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants