Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Hash the admin password of AWS directory services in statefile #9848

Closed

Conversation

dougneal
Copy link
Contributor

@dougneal dougneal commented Nov 3, 2016

Implement a StateFunc against the password attribute of aws_directory_service_directory to generate a SHA-256 hash of the password instead of storing the password in the statefile in the clear.

Additionally, set Sensitive: true for the password attribute.

Increment the SchemaVersion of aws_directory_service_directory to 1, and implement schema migration functions and associated tests.

@dougneal dougneal changed the title Hash the admin password of AWS directory services Hash the admin password of AWS directory services in statefile Nov 4, 2016
@dougneal dougneal changed the title Hash the admin password of AWS directory services in statefile provider/aws: Hash the admin password of AWS directory services in statefile Nov 10, 2016
@dougneal dougneal force-pushed the aws_directory_service_hashpassword branch from ffe54df to 4d9dbb3 Compare December 9, 2016 10:39
Implement a `StateFunc` against the `password` attribute of
`aws_directory_service_directory` to generate a SHA-256 hash of the
password instead of storing the password in the statefile in the clear.

Additionally, set `Sensitive: true` for the `password` attribute.

Increment the `SchemaVersion` of `aws_directory_service_directory` to 1,
and implement schema migration functions and associated tests.
@dougneal dougneal force-pushed the aws_directory_service_hashpassword branch from 4d9dbb3 to 6425f91 Compare December 9, 2016 16:42
@dougneal
Copy link
Contributor Author

@catsby @stack72 any chance of getting this into 0.8? :)

@apparentlymart
Copy link
Contributor

Hello @dougneal, and thanks for working on this!

As part of the the Terraform 0.10 release earlier this year, all of the Terraform providers were moved to their own repositories in the terraform-providers GitHub organization, and removed from the Terraform Core repository.

Unfortunately due to the fact that new issues and pull requests are being opened constantly, it was not possible for the various provider maintainers to merge all outstanding pull requests before this split, and there is no automatic way to migrate a pull request to a new repository.

As a result, this pull request can sadly no longer be applied as-is, and so I'm going to close it.

If you or someone else has the time and motivation to apply same changes to the aws provider repository and open a new PR there, the maintainers of that provider should be able to review and merge it.

Thanks again for working on this, and sorry it was not able to be merged before the provider repository changes.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants