Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for external_id and session_name in s3 backend assume_role #13234

Closed
bjornrog opened this issue Mar 31, 2017 · 2 comments · Fixed by #13236
Closed

Support for external_id and session_name in s3 backend assume_role #13234

bjornrog opened this issue Mar 31, 2017 · 2 comments · Fixed by #13236

Comments

@bjornrog
Copy link

We need support for external_id in the s3 backend, so we can use the same credentials as for the aws provider.

I have looked at the code and it seems to be a very simple fix, as the AWS auth mechanism used by the backend is the same as for the aws provider.

I have written a working version, but was not able to branch (ERROR: Permission to hashicorp/terraform.git denied to ...).

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Mar 31, 2017

Update: looks like @stack72 has already submitted a Pull Request to cover this 😄 (this didn't appear until I'd refreshed the page!)


Hi @bjornrog

Thanks for both reporting and taking a look into this :)

I have written a working version, but was not able to branch (ERROR: Permission to hashicorp/terraform.git denied to ...).

We're using Forks to allow contributors to propose changes to Terraform via Pull Requests - which means that (most) contributors don't have direct push access to this repository (which is the error you're seeing here).

It appears that you haven't created a Fork yet, so there's some more information available here - but essentially you can create a Fork by pressing the "fork" button in the top right of this page. Once the fork exists, you can add it to your local Terraform clone by using the following commands:

git remote add bjornrog git@github.com:bjornrog/terraform.git

At this point you should be able to push the changes to your Fork via:

git push bjornrog <branchname>

Once that's done - you can then open a Pull Request :)

Thanks!

stack72 added a commit that referenced this issue Mar 31, 2017
…ckend (#13236)

Fixes: #13234

This now matches the AWS provider for the Assume Role support
@ghost
Copy link

ghost commented Apr 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants