provider/aws: Fix dependency violation when deleting Internet Gateways #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Niiice - LGTM 🐑 |
catsby
added a commit
that referenced
this pull request
Mar 27, 2015
…lation provider/aws: Fix dependency violation when deleting Internet Gateways
This was referenced Mar 27, 2015
catsby
pushed a commit
that referenced
this pull request
Jul 7, 2016
This workaround is originally from 71b30c6. According to the commit message from Mitchell Hashimoto: So I think the AWS API is just broken here. In the case that the state doesn't update, just assume it did after 5 seconds. Based on my experience, this AWS API is still broken in the same way. The timeout was later increased from 5 seconds to 10 seconds in 265cc4f. The timeout (but not the timer) was removed inexplicably in GH-1325. The symptom is this error from `terraform apply`: aws_internet_gateway.test: Error waiting for internet gateway (igw-553b4731) to attach: timeout while waiting for state to become '[available]' followed by all subsequent `terraform apply` commands failing with this error: aws_internet_gateway.test: Resource.AlreadyAssociated: resource igw-553b4731 is already attached to network vpc-61bc7606
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-works how we handle detaching an Internet Gateway. Currently, we issue the
detachcall and wait for the state to become detached. If there was aDependencyViolationinvolving an EIP or VPC, we never retry thedetachcall, and simply return an error.This PR changes the behavior to issue the
detachcall in a refresh func, such that if there's an error we simply retry the call. This should resolve #1303, maybe others.