provider/aws: internetgateway timing tweaks (again)

[dtolnay]

This workaround is originally from 71b30c6. According to the commit message from Mitchell Hashimoto:

So I think the AWS API is just broken here. In the case that the state doesn't update, just assume it did after 5 seconds.

Based on my experience, this AWS API is still broken in the same way.

The timeout was later increased from 5 seconds to 10 seconds in 265cc4f.

The timeout (but not the timer) was removed inexplicably in GH-1325.

The symptom is this error from terraform apply:

aws_internet_gateway.test: Error waiting for internet gateway (igw-553b4731) to attach: timeout while waiting for state to become '[available]'

followed by all subsequent terraform apply commands failing with this error:

aws_internet_gateway.test: Resource.AlreadyAssociated: resource igw-553b4731 is already attached to network vpc-61bc7606

[catsby]

Looks good, thanks!

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInternetGateway -timeout 120m
=== RUN   TestAccAWSInternetGateway_importBasic
--- PASS: TestAccAWSInternetGateway_importBasic (29.40s)
=== RUN   TestAccAWSInternetGateway_basic
--- PASS: TestAccAWSInternetGateway_basic (53.29s)
=== RUN   TestAccAWSInternetGateway_delete
--- PASS: TestAccAWSInternetGateway_delete (37.00s)
=== RUN   TestAccAWSInternetGateway_tags
--- PASS: TestAccAWSInternetGateway_tags (39.73s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    159.464s
Test:

Re: GH-1325 , not sure what happened there, sorry about that :/

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.