providers/aws: Update ElasticTranscoderPreset to have default for MaxFrameRate

[catsby]

Updates video.max_frame_rate attribute to supply a default of 30, matching our Docs and AWS docs:

• http://docs.aws.amazon.com/elastictranscoder/latest/developerguide/create-preset.html

Fixes test TestAccAWSElasticTranscoderPreset_basic

[stack72]

@catsby as this now has a default, and is marked as ForceNew: true, will this cause any issues for some users? Do we need a State Migration for those who don't have it set?

[catsby]

@stack72 The API defaults it to 30. Any user omitting max_frame_rate is getting a ForceNew diff . Any user specifying max_frame_rate should see no change.

[stack72]

@catsby nice :) LGTM then

[svanzoest]

@catsby This broke #9847 and undid #11340, I can no longer set a preset with a fixed frame rate in 0.9.3, this was the reason the default was removed in the first place.

I now get:

* aws_elastictranscoder_preset.proxy: Error creating Elastic Transcoder Preset: ValidationException: When you specify a value for MaxFrameRate, you must also specify 'FrameRate':'Auto'. Either change the value of FrameRate or remove the MaxFrameRate object, and resubmit the request.
    status code: 400, request id: 8cf3908f-207e-11e7-84a3-01d702018b22

[dcosson]

I also ran into this problem and can't set a fixed frame rate.

Is the fix as simple as reverting this single line?

I can't tell since there's not really any context here explaining what the purpose of this PR was. Why should terraform ever have its own opinion on a default value if AWS specifically allows that value to be omitted?

[svanzoest]

@dcosson this is now tracked as hashicorp/terraform-provider-aws#695 will address this issue. I think the only reason it got added by terraform as it made the tests easier. See #13638 for some of the back story.

[dcosson]

Got it, thanks for updating with the more in-depth comment.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.