Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: data source for aws_kinesis_stream #13521

Closed
cbroglie opened this issue Apr 11, 2017 · 4 comments · Fixed by #13562
Closed

Feature Request: data source for aws_kinesis_stream #13521

cbroglie opened this issue Apr 11, 2017 · 4 comments · Fixed by #13562

Comments

@cbroglie
Copy link
Contributor

cbroglie commented Apr 11, 2017

We process Kinesis Streams using ECS containers, and we need to scale the number of containers based on the number of shards in each stream. Since our ECS configuration is driven through Terraform, it would be great if we could access the shard count for a given stream via a data source.

I'm planning on submitting a PR for this, and will be exposing the following attributes which are returned by the DescribeStream and ListTagsForStream APIs:

  • arn (string)
  • closed_shards (list of shard ids)
  • creation_timestamp (int)
  • name (string)
  • open_shards (list of shard ids)
  • retention_period (int)
  • shard_level_metrics (list of metrics)
  • status (string)
  • tags (map)

The only argument will be name. Let me know if this sounds reasonable.

cbroglie pushed a commit to cbroglie/terraform that referenced this issue Apr 11, 2017
This fixes hashicorp#13521.

This is the initial functioning implementation, but the docs still need
to be updated, and a test needs to be written to validate the open and
closed shards after an UpdateShardCount operation.
@cbroglie
Copy link
Contributor Author

I still need to improve the tests and update the docs, but feedback on the initial implementation would be welcome, thanks

@cbroglie
Copy link
Contributor Author

Ok #13558 is ready to go

@cbroglie
Copy link
Contributor Author

Actually I rebased the commits, #13562 is the new PR.

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants