provider/aws: Add aws_kinesis_stream data source

[cbroglie]

This fixes #13521

[cbroglie]

Is there any ETA for when this can be reviewed/merged? Thanks!

[stack72]

Hi @cbroglie

Thanks for the PR here - I am slightly worried by this. There is a change of functionality that may affect users and what they see in their plans

What are your thoughts on this?

Paul

[stack72]

Why change this to OpenShards?

[cbroglie]

There is no actual change in behavior here, the value of s.shardCount before was the number of open shards. And since I'm now storing the actual list of open shard ids, we can derive the shard count from it rather than storing it separately.

[stack72]

Got it :)

[stack72]

LGTM :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSKinesisStream'           130 ↵ ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/20 21:56:07 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSKinesisStream -timeout 120m
=== RUN   TestAccAWSKinesisStreamDataSource
--- PASS: TestAccAWSKinesisStreamDataSource (236.20s)
=== RUN   TestAccAWSKinesisStream_basic
--- PASS: TestAccAWSKinesisStream_basic (81.26s)
=== RUN   TestAccAWSKinesisStream_shardCount
--- PASS: TestAccAWSKinesisStream_shardCount (168.87s)
=== RUN   TestAccAWSKinesisStream_retentionPeriod
--- PASS: TestAccAWSKinesisStream_retentionPeriod (183.57s)
=== RUN   TestAccAWSKinesisStream_shardLevelMetrics
--- PASS: TestAccAWSKinesisStream_shardLevelMetrics (190.96s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	860.897s

[cbroglie]

Thanks!

[stack72]

You rock sir! Thanks for all the work :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.