Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing root_block_device in aws_launch_configuration results in no planned change #14503

Closed
jurajseffer opened this issue May 15, 2017 · 2 comments · Fixed by #14507
Closed

Changing root_block_device in aws_launch_configuration results in no planned change #14503

jurajseffer opened this issue May 15, 2017 · 2 comments · Fixed by #14507
Labels
bug provider/aws

Comments

@jurajseffer
Copy link

Terraform Version

Terraform v0.8.8

Affected Resource(s)

aws_launch_configuration

Terraform Configuration Files

resource "aws_launch_configuration" "logstash" {
  ...
  lifecycle {
    create_before_destroy = true
  }
  root_block_device {
    volume_type           = "gp2"
    volume_size           = 100
    delete_on_termination = true
  }
}

Expected Behavior

Changing the volume_size, volume_type etc should result in change being planned for the launch configuration.

Actual Behavior

No change is planned. This happens also once the entire root_block_device block is removed.
stack72 added a commit that referenced this issue May 15, 2017
@stack72
provider/aws: ForceNew aws_launch_config when root_block_device changes
56946c1 
Fixes: #14503

Changes to root_block_device were not picked up as we had a hash func to
return 0. We changed from set -> list as we only allow 1 value and
immediately we can get changes propagating

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLaunchConfiguration_updateRootBlockDevice'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/15 19:27:39 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLaunchConfiguration_updateRootBlockDevice -timeout 120m
=== RUN   TestAccAWSLaunchConfiguration_updateRootBlockDevice
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (51.12s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	51.140s
```
@stack72 stack72 mentioned this issue May 15, 2017
Merged
@stack72
Copy link
Contributor

stack72 commented May 15, 2017

Hi @jurajseffer

I just opened a PR that fixes this issue

Thanks

Paul

stack72 added a commit that referenced this issue May 15, 2017
@stack72
provider/aws: ForceNew aws_launch_config when root_block_device chang…
0a64529 
…es (#14507)

Fixes: #14503

Changes to root_block_device were not picked up as we had a hash func to
return 0. We changed from set -> list as we only allow 1 value and
immediately we can get changes propagating

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLaunchConfiguration_updateRootBlockDevice'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/15 19:27:39 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLaunchConfiguration_updateRootBlockDevice -timeout 120m
=== RUN   TestAccAWSLaunchConfiguration_updateRootBlockDevice
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (51.12s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	51.140s
```
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

provider/aws: ForceNew aws_launch_config when root_block_device changes hashicorp/terraform
3 participants
@stack72 @jurajseffer @grubernaut