provider/aws: Retry ECS service update on InvalidParameterException

[radeksimko]

This is to address the following test failure:

=== RUN   TestAccAWSEcsService_withLbChanges
--- FAIL: TestAccAWSEcsService_withLbChanges (26.37s)
    testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_ecs_service.with_lb_changes: 1 error(s) occurred:
        
        * aws_ecs_service.with_lb_changes: InvalidParameterException: Unable to assume role and validate the listeners configured on your load balancer. Please verify that the ECS service role being passed has the proper permissions.
            status code: 400, request id: de0cd152-3c58-11e7-b8c6-7502821aaf89

Closes #4375

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcsService_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/21 12:08:11 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcsService_ -timeout 120m
=== RUN   TestAccAWSEcsService_withIamRole
--- PASS: TestAccAWSEcsService_withIamRole (124.48s)
=== RUN   TestAccAWSEcsService_withDeploymentValues
--- PASS: TestAccAWSEcsService_withDeploymentValues (120.11s)
=== RUN   TestAccAWSEcsService_withLbChanges
--- PASS: TestAccAWSEcsService_withLbChanges (236.96s)
=== RUN   TestAccAWSEcsService_withEcsClusterName
--- PASS: TestAccAWSEcsService_withEcsClusterName (114.06s)
=== RUN   TestAccAWSEcsService_withAlb
--- PASS: TestAccAWSEcsService_withAlb (317.20s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	912.845s

[stack72]

LGTM - merging to get this in tonight's test run

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.