Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Retry ECS service update on InvalidParameterException #14708

Merged
merged 1 commit into from
May 21, 2017

Conversation

radeksimko
Copy link
Member

This is to address the following test failure:

=== RUN   TestAccAWSEcsService_withLbChanges
--- FAIL: TestAccAWSEcsService_withLbChanges (26.37s)
    testing.go:280: Step 0 error: Error applying: 1 error(s) occurred:
        
        * aws_ecs_service.with_lb_changes: 1 error(s) occurred:
        
        * aws_ecs_service.with_lb_changes: InvalidParameterException: Unable to assume role and validate the listeners configured on your load balancer. Please verify that the ECS service role being passed has the proper permissions.
            status code: 400, request id: de0cd152-3c58-11e7-b8c6-7502821aaf89

Closes #4375

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcsService_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/21 12:08:11 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcsService_ -timeout 120m
=== RUN   TestAccAWSEcsService_withIamRole
--- PASS: TestAccAWSEcsService_withIamRole (124.48s)
=== RUN   TestAccAWSEcsService_withDeploymentValues
--- PASS: TestAccAWSEcsService_withDeploymentValues (120.11s)
=== RUN   TestAccAWSEcsService_withLbChanges
--- PASS: TestAccAWSEcsService_withLbChanges (236.96s)
=== RUN   TestAccAWSEcsService_withEcsClusterName
--- PASS: TestAccAWSEcsService_withEcsClusterName (114.06s)
=== RUN   TestAccAWSEcsService_withAlb
--- PASS: TestAccAWSEcsService_withAlb (317.20s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	912.845s

@stack72
Copy link
Contributor

stack72 commented May 21, 2017

LGTM - merging to get this in tonight's test run

@stack72 stack72 merged commit 3a41e45 into master May 21, 2017
@stack72 stack72 deleted the b-aws-ecs-svc-retry branch May 21, 2017 19:19
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS Service erroring out due to eventually-consistent IAM role
2 participants