Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for separate VPC Security Group IDs attribute #1539

Merged
merged 7 commits into from
Apr 15, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Apr 15, 2015

Successor to #1153. Not strictly rebased on master because the file has changed considerably since the original was opened, but I believe I've captured the intent in all the right places.

ColinHebert and others added 7 commits March 7, 2015 17:04
* master: (511 commits)
  Update CHANGELOG.md
  core: avoid diff mismatch on NewRemoved fields during -/+
  Update CHANGELOG.md
  update CHANGELOG
  Fix minor error in index/count docs
  terraform: remove debug
  terraform: when pruning destroy, only match exact nodes, or exact counts
  up version for dev
  update CHANGELOG
  terraform: prune tainted destroys if no tainted in state [GH-1475]
  update CHANGELOG
  config/lang: support math on variables through implicits
  update CHANGELOG
  update cHANGELOG
  update cHANGELOG
  providers/aws: set id outside if/esle
  providers/aws: set ID after creation
  core: remove dead code from pre-deposed refactor
  website: update LC docs to note name is optional
  security_groups field expects a list of Security Group Group Names, not IDs
  ...
@catsby catsby mentioned this pull request Apr 15, 2015
@catsby catsby changed the title F aws instance vpc sec ids provider/aws: Add support for separate VPC Security Group IDs attribute Apr 15, 2015
@phinze
Copy link
Contributor

phinze commented Apr 15, 2015

Yeah nicer to separate these out. 👍

catsby added a commit that referenced this pull request Apr 15, 2015
provider/aws: Add support for separate VPC Security Group IDs attribute
@catsby catsby merged commit e97fd27 into master Apr 15, 2015
@catsby catsby deleted the f-aws-instance-vpc-sec-ids branch April 15, 2015 20:25
@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants