Vpc security group ids #1153
Vpc security group ids #1153
Conversation
| sgs[i] = sg.Id | ||
| } | ||
| // Keep some backward compatibility. The user is warned on creation. | ||
| if d.Get("security_groups") != nil { |
There was a problem hiding this comment.
This should prevent the recreation of instances in VPC when the user is still using security_groups in a VPC environment.
It should be removed at some stage.
|
Hey @ColinHebert , thanks for the contribution! Let me know if you have any questions |
| var g ec2.SecurityGroup | ||
| g.Id = str | ||
|
|
||
| runOpts.SecurityGroups = append(runOpts.SecurityGroups, g) |
There was a problem hiding this comment.
should this be runOpts.SecurityGroupIDs ?
SecurityGroups is a collection of Security Group names.
catsby
added
enhancement
waiting-response
|
succeeded by #1539 , which is up to date with master |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
In a VPC environment the security groups on instances can be changed without having to recreate the instance.
The current
security_groupsparameter forces the recreation of the instance. To allow VPC users to change their configuration, a different parameter can be used (vpc_security_groups_ids, which matches the model we have inaws_db_instance).This PR adds the said parameter
Should be a first step to fix #749