Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If apply generates a cycle, plan should generate the same cycle, and graph should display the cycle #1651

Closed
phinze opened this issue Apr 23, 2015 · 2 comments
Assignees

Comments

@phinze
Copy link
Contributor

phinze commented Apr 23, 2015

Because of the graph pruning that happens during plan, there are many cycles that don't reveal themselves until the apply step. This breaks the plan/apply contract.

I've been tracking this issue myself for a while now, and I've nearly completed a fix. But I wanted to file an issue to center the PR around.

phinze added a commit that referenced this issue Apr 23, 2015
Most CBD-related cycles include destroy nodes, and destroy nodes were
all being pruned from the graph before staring the Validate walk.

In practice this meant that we had scenarios that would error out with
graph cycles on Apply that _seemed_ fine during Plan.

This introduces a Verbose option to the GraphBuilder that tells it to
generate a "worst-case" graph. Validate sets this to true so that cycle
errors will always trigger at this step if they're going to happen.

(This Verbose option will be exposed as a CLI flag to `terraform graph`
in a second incoming PR.)

refs #1651
@phinze phinze self-assigned this Apr 25, 2015
@phinze
Copy link
Contributor Author

phinze commented May 6, 2015

With #1816 this is done.

@phinze phinze closed this as completed May 6, 2015
@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant