Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error retreiving EIP from AWS on v0.4.2 #1696

Closed
geofffranks opened this issue Apr 27, 2015 · 5 comments · Fixed by #1701
Closed

Error retreiving EIP from AWS on v0.4.2 #1696

geofffranks opened this issue Apr 27, 2015 · 5 comments · Fixed by #1701

Comments

@geofffranks
Copy link

When I try to do a terraform refresh of an already deployed AWS VPC, using binaries built off of the v0.4.2 tag (or later commits), I get the following error:

{code}
Error refreshing state: 1 error(s) occurred:

  • 1 error(s) occurred:
  • 1 error(s) occurred:

Error retrieving EIP: InvalidParameterValue: Invalid value '' for PublicIp. Not a valid IPv4 address.
{code}

However, if I use the released v0.4.2 binaries, this problem does not occur. Am I doing something stupid? I'm trying to get the rep-built terraform to work, so I can test out the f-aws-security-group-rule-resource branch.
@jstremick
Copy link

@geofffranks , I ran into this while implementing #1468 and resolved it on the related PR. I believe the switch to the official AWS SDK caused this. The goamz library would ignore empty values provided to requests but aws-sdk-go prefers that those values be omitted instead.

@wazoo
Copy link

wazoo commented Apr 27, 2015

This bug still exists as of 0.5.0-dev 3d36779

phinze added a commit that referenced this issue Apr 28, 2015
@phinze
provider/aws: fix EIPs on new upstream sdk
120cfdc 
As we've seen elsewhere, the SDK now wants nils instead of empty arrays
for collections

fixes #1696

thanks @jstremick for pointing me in the right direction
@phinze phinze mentioned this issue Apr 28, 2015
Merged
@wazoo
Copy link

wazoo commented Apr 28, 2015

Updated to 764bdbc in master and this is fixed, thanks!

@geofffranks
Copy link
Author

Confirmed fixed on my end too, thanks!

@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

provider/aws: fix EIPs on new upstream sdk hashicorp/terraform
3 participants
@wazoo @jstremick @geofffranks