provider/aws: add aws_route53_health_check (rebase,squash+docs) #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamdor
force-pushed
the
add-aws-route53-health-checks-squashed
branch
from
293a7dc to
054a404
Compare
|
👍 |
|
@rubbish this looks basically perfect - great work! 😀 The docs are just missing a sidebar link, which I'll add on master post-merge. |
phinze
added a commit
that referenced
this pull request
Jun 15, 2015
…ashed provider/aws: add aws_route53_health_check (rebase,squash+docs)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same commits as #1984, but squashed into one and rebased on top of current master. I also added website docs for the new resource. This can supersede that pull request.
@catsby @trentio @nicgrayson