provider/aws: Add aws route53 health checks

[nicgrayson]

This PR adds a resource for route53 health checks.

[catsby]

Typically, yes.
For instance, if you do not check with d.GetOk, I believe d.Get will give you an empty string for string values not found/required. You'll then pass that on to the API as a string pointer with value "", and the API will complain that isn't a valid value.

[nicgrayson]

@catsby Those 2 comments should be cleared up now

[catsby]

This doesn't have a refresh func attached to it anymore, do this do anything?

[catsby]

I'm getting a panic when running either of the supplied tests, looks like some more work is needed here:

2015/05/18 13:40:49 [DEBUG] apply: aws_route53_health_check.foo: executing Apply
2015/05/18 13:40:49 [DEBUG] Waiting for state to become: accepted
2015/05/18 13:40:49 [TRACE] Waiting 1s before next try
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x36cf91]

goroutine 39 [running]:
github.com/hashicorp/terraform/helper/resource.func·001()

[catsby]

Is there a reason for this change? schema.HashString is a newer thing, shortcut for the Set: func you have above. Is this from a bad merge/rebase maybe?

[nicgrayson]

It's hashstring on master: https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/resource_aws_route53_record.go#L96

[catsby]

So why are we changing it back to func in this pull request?

[nicgrayson]

You are right. Fixed.

[nicgrayson]

@catsby I've fixed up the create to remove the wait altogether. You were right, we didn't need that for this call.

[nicgrayson]

I would love to see this merged. Let me know if anything needs to be done for that to happen.

[knuckolls]

We're using this internally on a fork of terraform. Would love to see it merged or additional feedback if needed.

[knuckolls]

Should we close this in favor of #2226? @nicgrayson @rubbish

[catsby]

#2226 seems to omit @nicgrayson from the contributors, if he's OK with that then I think we should move forward with it

[nicgrayson]

@catsby That is fine, I just want it merged 😄

[radeksimko]

Closing in favor of #2226

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.