Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow AWS LaunchConfiguration auto-generated name with a user defined prefix #2911

Closed
xuwang opened this issue Aug 2, 2015 · 9 comments
Closed

Allow AWS LaunchConfiguration auto-generated name with a user defined prefix #2911

xuwang opened this issue Aug 2, 2015 · 9 comments
Labels
enhancement provider/aws

Comments

@xuwang
Copy link
Contributor

xuwang commented Aug 2, 2015

Terraform auto generated lc name is a nice feature combined with CBD to allow lc update. It currently
generates a lc name terraform-<uniqueid>.

It would be very helpful to allow a user defined prefix, for example, etcd-cluster-<uniqueid>.
I would think to add a name_prefix attribute, or auto_name_versioning flag so that the lc name will be used as the prefix.
@xueshanf
Copy link

xueshanf commented Aug 3, 2015

+1
It'd be useful to query launch configuration based on a specific prefix in lc name.

@ericfode
Copy link

ericfode commented Aug 3, 2015

+1

@pforman
Copy link
Contributor

pforman commented Aug 5, 2015

+1, this would be really nice to have given that the dependency cycle issues in LC vs ASG effectively require auto-generated names.

@freeman
Copy link
Contributor

freeman commented Aug 14, 2015

+1

@nathanpalmer
Copy link

Yes agree. I just ran into an issue where we need to use create_before_destroy but it can't be done while we're explicitly naming the resource. I'd like to at-least have some sort of prefix or a variable that I can use that includes an autogenerated id

@CpuID
Copy link
Contributor

CpuID commented Sep 1, 2015

+1, definitely would be nice for identification purposes.

@mrfoobar1
Copy link

+1, you can't delete the LC if it's being used with an AS.

pforman pushed a commit to pforman/terraform that referenced this issue Nov 7, 2015
providers/aws: add name_prefix option to launch config
4d640c6 
See hashicorp#2911.

This adds a `name_prefix` option to `aws_launch_configuration` resources.

When specified, it is used instead of `terraform-` as the prefix for the
launch configuration.  It conflicts with `name`, so existing
functionality is unchanged.  `name` still sets the name explicitly.

Added an acceptance test, and updated the site documentation.
@pforman pforman mentioned this issue Nov 7, 2015
Merged
@catsby
Copy link
Contributor

catsby commented Nov 10, 2015

Hey all – thanks for opening the issue. @pforman graciously added this in #3802 and I just merged it.

@catsby catsby closed this as completed Nov 10, 2015
dpetzold pushed a commit to clearcare/terraform that referenced this issue Nov 12, 2015
providers/aws: add name_prefix option to launch config
b35f55d 
See hashicorp#2911.

This adds a `name_prefix` option to `aws_launch_configuration` resources.

When specified, it is used instead of `terraform-` as the prefix for the
launch configuration.  It conflicts with `name`, so existing
functionality is unchanged.  `name` still sets the name explicitly.

Added an acceptance test, and updated the site documentation.
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@freeman @ericfode @catsby @nathanpalmer @radeksimko @CpuID @pforman @xuwang @xueshanf @mrfoobar1