provider/gce: VPN resources, documentation, tests and example #3213
Conversation
| @@ -7,6 +7,7 @@ FEATURES: | |||
| * **New resource: `google_compute_project_metadata`** [GH-3065] | |||
| * **New resources: `aws_ami`, `aws_ami_copy`, `aws_ami_from_instance`** [GH-2874] | |||
| * **New resource: `google_storage_bucket_object`** [GH-3192] | |||
| * **New resources: `google_compute_vpn_gateway`, `google_compute_vpn_tunnel`** [GH-3213] | |||
There was a problem hiding this comment.
FYI: The changelog is something maintainers update via github web iface when they're merging the PR to avoid any potential conflicts.
There was a problem hiding this comment.
Ah, I was hoping I was saving you the trouble of updating that, sorry!
There was a problem hiding this comment.
I didn't know you could do it when merging, I used to do a separate commit after the merge. How do you do it?
There was a problem hiding this comment.
I usually just do it via github web iface. AFAIK others do as well.
|
I ran both acceptance tests - worked aok. Just left you a few notes about docs, formatting and schema. |
| resource "google_compute_vpn_tunnel" "tunnel1" { | ||
| name = "tunnel1" | ||
| region = "${var.region}" | ||
| peer_ip = 15.0.0.120 |
There was a problem hiding this comment.
Can you also escape this as string? otherwise it's invalid syntax. 😉
|
I squashed my changes, and modified (and tested) the example to set up a VPN between networks in different regions. @sparkprime |
lwander
changed the title
|
LGTM |
provider/gce: VPN resources, documentation, tests and example
* oss/master: Add 'discard' target to file audit backend (hashicorp#3262) changelog++ auth/aws: Allow wildcard in bound_iam_principal_id (hashicorp#3213) changelog++ Add option to set cluster TLS cipher suites. (hashicorp#3228)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
These were the missing components required for creating VPNs in GCE using Terraform.