provider/aws: db_parameter_group name validation

[stack72]

Adding a small note to the docs for db_parameter_group to show it needs to be lowercase. The use of UpperCase characters will continually show changes to the resource

This was reported in IRC http://paste.in.ua/543/

[radeksimko]

http://docs.aws.amazon.com/cli/latest/reference/rds/create-db-parameter-group.html

👍

Feel free to add a test later.

[apparentlymart]

Regarding the requirement for lowercase:

In some other similar cases recently (#3120 and #3235) we addressed the "stored as lowercase" issue by normalizing rather than validating the string. In those cases AWS doesn't reject a string with uppercase letters, but rather just converts them to lowercase.

I thought doing the same thing in Terraform was the right choice because it allows the name to be produced by interpolating something that might contain uppercase letters and have that be accepted. I'm not sure if such an approach is appropriate here too, but figured I'd point this out in the interests of consistency.

[stack72]

@apparentlymart I agree there are inconsistencies across the codebase for this. I guess a decision can be made on what needs to happen to it and I will gladly change the code

I will defer this decision to you folks though

[radeksimko]

I thought doing the same thing in Terraform was the right choice because it allows the name to be produced by interpolating something that might contain uppercase letters and have that be accepted. I'm not sure if such an approach is appropriate here too, but figured I'd point this out in the interests of consistency.

I hear you there, I've been always advocating for stricter checks, so that the DSL/code will equal to the reality and less magic happens.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.