provider/aws: Added a set of tests for the DBParamGroup Name

[stack72]

make testacc TEST=./builtin/providers/aws TESTARGS='-run=DBParameterGroup' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=DBParameterGroup -timeout 90m
=== RUN   TestAccAWSDBParameterGroup_basic
--- PASS: TestAccAWSDBParameterGroup_basic (6.04s)
=== RUN   TestAccAWSDBParameterGroupOnly
--- PASS: TestAccAWSDBParameterGroupOnly (3.76s)
=== RUN   TestResourceAWSDBParameterGroupName_uppercaseCharacter
--- PASS: TestResourceAWSDBParameterGroupName_uppercaseCharacter (0.00s)
=== RUN   TestResourceAWSDBParameterGroupName_specialCharacters
--- PASS: TestResourceAWSDBParameterGroupName_specialCharacters (0.00s)
=== RUN   TestResourceAWSDBParameterGroupName_firstCharacterNumber
--- PASS: TestResourceAWSDBParameterGroupName_firstCharacterNumber (0.00s)
=== RUN   TestResourceAWSDBParameterGroupName_doubleHyphen
--- PASS: TestResourceAWSDBParameterGroupName_doubleHyphen (0.00s)
=== RUN   TestResourceAWSDBParameterGroupName_trailingHyphen
--- PASS: TestResourceAWSDBParameterGroupName_trailingHyphen (0.00s)
=== RUN   TestResourceAWSDBParameterGroupName_tooManyCharacters
--- PASS: TestResourceAWSDBParameterGroupName_tooManyCharacters (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    9.815s

@radeksimko as requested in #3279

[stack72]

@radeksimko I added a small func that creates a RandomString of fixed length. This may be useful for other tests. If you think that should be moved to a different location then let me know

[catsby]

Lots of tests! Since they're all testing the same method with different inputs, can we re-write this to be a table test?

func TestResourceAWSDBParameterGroupName_validation(t *testing.T) {
    cases := []struct {
        Value    string
        ErrCount int
    }{
        {
            Value:    "tEsting123",
            ErrCount: 1,
        },
        {
            Value:    "testing123!",
            ErrCount: 1,
        },
               # [.. so on ..]
    }

    for _, tc := range cases {
        _, errors := validateDbParamGroupName(tc.Value, "SampleKey")
        if len(errors) != ErrCount {
            t.Fatalf("Expected the DB Parameter Group Name to trigger a validation error")
        }
    }
}

[stack72]

ooohhh! I didn't realise this. Updating right now

Thanks @catsby

[catsby]

Small nitpicks but otherwise 👍

[stack72]

Thanks @catsby! This is now taken care of :) (This is a really useful Go tip for me!)

make testacc TEST=./builtin/providers/aws TESTARGS='-run=DBParameterGroup' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=DBParameterGroup -timeout 90m
=== RUN   TestAccAWSDBParameterGroup_basic
--- PASS: TestAccAWSDBParameterGroup_basic (5.58s)
=== RUN   TestAccAWSDBParameterGroupOnly
--- PASS: TestAccAWSDBParameterGroupOnly (2.84s)
=== RUN   TestResourceAWSDBParameterGroupName_validation
--- PASS: TestResourceAWSDBParameterGroupName_validation (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    8.472s

[stack72]

@catsby this build is working on my local machine but yet fails on travis. Any reason why?

[stack72]

ok false alarm - this was due to an edgecase in my tests where the randomString generator could have given me a string starting with a number and thus failed the test

[catsby]

ok false alarm - this was due to an edgecase in my tests where the randomString generator could have given me a string starting with a number and thus failed the test

Glad you figured it out, I was confused as well since it was passing for me. resource has a uniqueID method, maybe you can borrow code from that?

Either way, I assume you're patching? Thanks!

[stack72]

@catsby all patched and ready for merge :)

[catsby]

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.