-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Add support for EC2 Placement Group #3457
provider/aws: Add support for EC2 Placement Group #3457
Conversation
b23e545
to
78f76b9
Compare
Required: true, | ||
ForceNew: true, | ||
}, | ||
"strategy": &schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should set a default value of Cluster
here as it is the only supported value atm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah but we need to have ForceNew
enabled if there is no update :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite convinced it's a good idea to make it default, but I don't know Amazon's plans for the future.
This looks good. The only issue I would have with it is that we allow any value as the |
I've tested this and it looks good - i guess this can be merged pretty easily :) |
@phinze FYI, I checked this branch out and was able to manage placement groups with it. So I can very this is good |
Looking good! Nice work as usual @radeksimko 😀 |
provider/aws: Add support for EC2 Placement Group
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Test plan