Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for EC2 Placement Group #3457

Merged
merged 3 commits into from
Oct 12, 2015

Conversation

radeksimko
Copy link
Member

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=PlacementGroup' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=PlacementGroup -timeout 90m
=== RUN   TestAccAWSPlacementGroup_basic
--- PASS: TestAccAWSPlacementGroup_basic (6.99s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    7.012s

Required: true,
ForceNew: true,
},
"strategy": &schema.Schema{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should set a default value of Cluster here as it is the only supported value atm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah but we need to have ForceNew enabled if there is no update :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite convinced it's a good idea to make it default, but I don't know Amazon's plans for the future.

@stack72
Copy link
Contributor

stack72 commented Oct 8, 2015

This looks good. The only issue I would have with it is that we allow any value as the strategy and then wait for AWS to validate the input but that's just $0.02 :)

@stack72
Copy link
Contributor

stack72 commented Oct 11, 2015

I've tested this and it looks good - i guess this can be merged pretty easily :)

@stack72
Copy link
Contributor

stack72 commented Oct 12, 2015

@phinze FYI, I checked this branch out and was able to manage placement groups with it. So I can very this is good

@phinze
Copy link
Contributor

phinze commented Oct 12, 2015

Looking good! Nice work as usual @radeksimko 😀

phinze added a commit that referenced this pull request Oct 12, 2015
provider/aws: Add support for EC2 Placement Group
@phinze phinze merged commit 6172138 into hashicorp:master Oct 12, 2015
@radeksimko radeksimko deleted the f-aws-ec2-placement-groups branch October 12, 2015 21:17
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants