Added measure_latency option to Route 53 Health Check resource. #3688
Conversation
| @@ -128,6 +133,10 @@ func resourceAwsRoute53HealthCheckCreate(d *schema.ResourceData, meta interface{ | |||
| healthConfig.ResourcePath = aws.String(v.(string)) | |||
| } | |||
|
|
|||
| if v, ok := d.GetOk("measure_latency"); ok { | |||
There was a problem hiding this comment.
Schema elements with a Default value do not need to be checked with GetOk; it will always be ok. Here, healthConfig.MeasureLatency = aws.Bool(d.Get("measure_latency").(bool)) is fine.
Also, since this is a boolean, if the user specified false in their configuration this block would never be entered. since GetOk checks for non-default values. Not that you should have known these things, just mentioning it 😄
|
Hey @ajvb thanks for the PR Looking at the documentation, I think we're missing a few things:
|
catsby
added
enhancement
waiting-response
|
It would also be create if we could check it's existence and value in |
|
@catsby Thank you for the feedback! Let me make those changes and push it up. |
|
@catsby This also seems to be the case for the |
|
It doesn't seem to be a thing that's currently being checked 😄 |
* Added ignoring of param when Type is CALCULATED * Added ForceNew param to measure_latency item in schema * Added check to test
|
@catsby Ok awesome, is there any else required of me before this gets merged in? |
catsby
removed
the
waiting-response
|
Hey @ajvb – terribly sorry for the delay here, I'm going to merge this in now. Thanks! |
Added measure_latency option to Route 53 Health Check resource.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Adds
measure_latencyoption to Route 53 Health Check resource.This allows for the health check to record request latency and graph it within the Route 53 UI.
Related to #3273