Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Supporting New AWS Route53 HealthCheck additions #3741

Closed
wants to merge 3 commits into from

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 3, 2015

Added:

  • measure_latency
  • invert_healthcheck
  • child_healthchecks
  • acceptance tests
  • documentation

There were a couple of key changes required here:

  1. failure_threshold was changed to optional as it is only required for non Calculated checks
  2. request_interval was changed to optional as it is only required for non Calculated checks

@stack72 stack72 mentioned this pull request Nov 3, 2015
@stack72 stack72 changed the title [WIP] provider/aws: Supporting New AWS Route53 HealthCheck additions provider/aws: Supporting New AWS Route53 HealthCheck additions Nov 3, 2015
@radeksimko
Copy link
Member

This is slightly overlapping with #3688

@stack72
Copy link
Contributor Author

stack72 commented Dec 28, 2015

@radeksimko what do you need me to do here?

@radeksimko
Copy link
Member

@stack72 I don't intend to review either of these (at least not in the nearest weeks), so I cannot say, I was merely adding the link so that whoever ends up reviewing & merging this feature is aware of it. 😉

@radeksimko
Copy link
Member

Closing this in favour of #4564 as mentioned in that PR.

@radeksimko radeksimko closed this Jan 10, 2016
catsby added a commit that referenced this pull request Jan 14, 2016
provider/aws: Supporting New AWS Route53 HealthCheck additions (supersedes #3741)
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants