provider/vsphere: rename vcenter_server config parameter to something clearer #3718
Conversation
tkak
changed the title
|
@tkak isn't vcenter more accurate? It is actually the api url on the vcenter server ... |
|
@chrislovecnm hmm..., I think the parameter has a use case in ESXi, not just vcenter server. |
|
@tkak indeed Do we have docs to update?? |
tkak
force-pushed
the
rename-config-parameters
branch
from
da24ffd
to
7bf0224
Compare
|
@chrislovecnm I updated the docs. Thanks! |
|
This LGTM. I'm going to follow up with a tweak to include the old field as supported but deprecated so we don't break any existing users with this, we can leave that for at least one release and clean it up in a future one. |
provider/vsphere: rename vcenter_server config parameter to something clearer
As promised in my comment in #3718, this preserves backwards compatibility while warning users of the new proper name for the field.
As promised in my comment in #3718, this preserves backwards compatibility while warning users of the new proper name for the field.
As promised in my comment in #3718, this preserves backwards compatibility while warning users of the new proper name for the field.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This fixes #3522.