v0.6.7 Release Process

[catsby]

v0.6.7 Release Process

cc @hashicorp/terraform-committers

We’re beginning the Release Process for Terraform v0.6.7. Part of this process is validating the master branch passes all of our current unit and acceptance tests. To better facilitate this, we’re temporarily suspending commit privilege for our team of core-committers. We’ll re-enable this as soon as the process concludes and v0.6.7 is out.

The CHANGELOG documents the changes that will be going out (0.6.7 Unreleased).

Core committers can highlight @catsby / @phinze / @jen20 for anything they feel needs immediate attention, otherwise we’re proceeding with minimal changes to the master branch as is.

Thanks!

[svanharmelen]

@catsby @phinze @jen20 I believe there is a bug in the new HCL related code... Hold on while I get you some more details...

[svanharmelen]

Yes, I can confirm there is a bug when you feed JSON configs to Terraform. You can test yourself by using the following config:

{
    "provider": {
        "cloudstack": {
            "api_url": "bla",
            "api_key": "bla",
            "secret_key": "bla"
        }
    },
    "resource": {
        "cloudstack_firewall": {
            "test": {
                "ipaddress": "192.168.0.1",
                "rule": [
                    {
                        "source_cidr": "10.0.0.0/8",
                        "protocol": "tcp",
                        "ports": [
                            "80",
                            "1000-2000"
                        ]
                    }
                ]
            }
        }
    }
}

Which will result in this output:

While if I run this (the HCL equivalent) it runs without any errors:

provider "cloudstack" {
  api_url = "bla"
  api_key = "bla"
  secret_key = "bla"
}

resource "cloudstack_firewall" "test" {
  ipaddress = "192.168.0.1"
  rule {
    source_cidr = "10.0.0.0/8"
    protocol = "tcp"
    ports = ["80", "1000-2000"]
  }
}

I need to go home now, but can try to fix/troubleshoot this after dinner later tonight if needed...

[mitchellh]

@svanharmelen Nice. Thanks for finding this. Let's turn this into a failing test (we can do it) and get it fixed prior to release.

[mitchellh]

@catsby Let's keep this open until we do the release! :)

[svanharmelen]

@mitchellh @catsby I just fixed the problem, but need to go to a (nasty) dentist appointment right now. Will put in a PR when I get back (within a few hours that is)...

[jen20]

Thanks @svanharmelen! I just added tests reproducing the issue on this branch: https://github.com/hashicorp/terraform/tree/b-json-hcl

[svanharmelen]

@jen20 yeah just noticed the commit 👍 Good to have this test in so we can verify the fix in Terraform as well.

The root cause was actually in the new/updated HCL code, so my PR will be on the HCL repo (with it's own test in the PR). But still a good thing to cover this issue here as well!

Be back in a few...

[svanharmelen]

The PR to fix this is in: hashicorp/hcl#61

[svanharmelen]

Seems there is still an issue with the new HCL code and JSON, as reported by @pikeas: #3988

Will have a look first thing tomorrow morning. We have some services talking (pretty complex) JSON to TF, so will run some additional tests with those tomorrow as well to make sure there are no other issues after fixing this new one.

[phinze]

Thanks for the heads up @svanharmelen. We'll make sure that gets addressed before release. 👍

[svanharmelen]

Have a fix, fixing up the PR as we speak...

[svanharmelen]

@phinze hashicorp/hcl#64 fixes the issue raised in #3988

Unfortunately I don't have time today to do some brute force testing against master in order to see if we have missed more/other use cases with the new HCL code in combination with JSON configs.

I think it's still wise to first do this, but I leave that decision with you guys. I will do these tests Monday morning so you'll have the results/feedback when your Monday morning begins 😉

[phinze]

Thanks @svanharmelen! Agreed on more JSON testing. I'll see what I can put together today, but we're likely looking at holding the release for Monday anyways, so you'll get your chance to do your thing as well. 😀

[svanharmelen]

👍

[svanharmelen]

@phinze just got around to testing some configs and as far as I can tell we are good to go 👍

[radeksimko]

I wanted to avoid merging changes at this time before release, there's just one I merged - #4010

This was to avoid breaking changes after the release. Full explanation inside the PR. Hopefully it won't cause any troubles - I double checked the code & tests.

[phinze]

Sounds good, @radeksimko, looks like a good call to me. 👍

[catsby]

v0.6.7 was released! Thank you all who contributed 😄