Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON variables still broken #3988

Closed
pikeas opened this issue Nov 19, 2015 · 5 comments
Closed

JSON variables still broken #3988

pikeas opened this issue Nov 19, 2015 · 5 comments

Comments

@pikeas
Copy link
Contributor

pikeas commented Nov 19, 2015

Following up on #3964 (comment-locked) and hashicorp/hcl#61, hopefully @svanharmelen or @catsby sees this.

The example on #3964 passes with Terraform compiled from master (after a make updatedeps to grab the latest HCL) @ 75d056c. But add a variable to the mix and we're still broken:

{
    "variable": {
      "foo": {}
    },
    "provider": {
        "cloudstack": {
            "api_url": "bla",
            "api_key": "bla",
            "secret_key": "bla"
        }
    },
    "resource": {
        "cloudstack_firewall": {
            "test": {
                "ipaddress": "${var.foo}",
                "rule": [
                    {
                        "source_cidr": "10.0.0.0/8",
                        "protocol": "tcp",
                        "ports": [
                            "80",
                            "1000-2000"
                        ]
                    }
                ]
            }
        }
    }
}
$ TF_VAR_foo=a terraform plan -refresh=false                                                                                                                                                               Error configuring: 1 error(s) occurred:

* cloudstack_firewall.test: missing dependency: var.foo

Works under 0.6.6, so this is a regression.

@pikeas pikeas changed the title JSON variables still broken. JSON variables still broken Nov 19, 2015
@svanharmelen
Copy link
Contributor

@pikeas thanks for the report! Will have a closer look at it when behind a desk again...

@mitchellh
Copy link
Contributor

For whoever tackles this, let's make sure to add a test to the config package for this as well as HCL.

@svanharmelen
Copy link
Contributor

@mitchellh @jen20 PR hashicorp/hcl#64 fixes this issue. As with the other issue I added a test in the PR so from a HCL package point of view we're covered 😉

@jen20
Copy link
Contributor

jen20 commented Nov 20, 2015

Thanks @svanharmelen! Since hashicorp/hcl#64 is now merged I'll go ahead and close this issue.

@jen20 jen20 closed this as completed Nov 20, 2015
omeid pushed a commit to omeid/terraform that referenced this issue Mar 30, 2018
…da_function-iam-retry-update

resource/aws_lambda_function: Add missing IAM retry in update
omeid pushed a commit to omeid/terraform that referenced this issue Mar 30, 2018
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants