Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Treat INACTIVE ECS cluster as deleted #4364

Merged
merged 1 commit into from
Dec 17, 2015

Conversation

radeksimko
Copy link
Member

Either Amazon has changed this behaviour/timeouts or this just slipped through for some reason.

The PR is fixing the following acceptance test failure:

=== RUN   TestAccAWSEcsCluster_basic
--- FAIL: TestAccAWSEcsCluster_basic (8.43s)
    testing.go:165: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: Check failed: ECS cluster still exists:
        []*ecs.Cluster{{
          ActiveServicesCount: 0,
          ClusterArn: "arn:aws:ecs:us-west-2:212346748836:cluster/red-grapes",
          ClusterName: "red-grapes",
          PendingTasksCount: 0,
          RegisteredContainerInstancesCount: 0,
          RunningTasksCount: 0,
          Status: "INACTIVE"
        }}

        State: <no state>

@phinze
Copy link
Contributor

phinze commented Dec 17, 2015

@radeksimko we recently found that the DestroyCheck portion of the AccTest suite has not been called correctly for some time, so these errors will probably flush themselves out over the next few weeks.

This LGTM!

radeksimko added a commit that referenced this pull request Dec 17, 2015
provider/aws: Treat INACTIVE ECS cluster as deleted
@radeksimko radeksimko merged commit a9803d6 into hashicorp:master Dec 17, 2015
@radeksimko radeksimko deleted the b-ecs-cluster-fixes branch December 17, 2015 16:10
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants