provider/aws: Treat CF stacks in DELETE_COMPLETE state as deleted

[radeksimko]

Similar to #4364 , as @phinze mentioned:

we recently found that the DestroyCheck portion of the AccTest suite has not been called correctly for some time

[phinze]

StackId and StackStatus can never be nil, correct? If so, this LGTM!

[radeksimko]

StackId and StackStatus can never be nil, correct?

That's a good question.

http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_DescribeStacks.html
^ that doesn't really answer this, so I reached out to the AWS support.

I can't think of a case where this wouldn't be included in the response, but I want to be sure before merging this. I will update this PR once I get response from them.

[radeksimko]

AWS support representative replied:

Regarding the response what reported here (http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_Stack.html) should be incorrect, because as far as I know and I also consulted several colleagues that everyday work CloudFormation cases, the StackId and the StackStatus are always returned.

For this reason I have forwarded the details of the problem to the service team and requested an investigation from them so that they can modify the documentation page accordingly.

so I'm merging this.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.