Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: EIP not noticing it has been unassigned from an ENI #4387

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

justnom
Copy link
Contributor

@justnom justnom commented Dec 18, 2015

Adding empty string defaults for network interface and instance when reading aws_eip resource.

Fixes #4351

Adding empty string defaults for network interface and instance when reading `aws_eip` resource.
@jen20
Copy link
Contributor

jen20 commented Dec 18, 2015

LGTM. Thanks @justnom!

jen20 added a commit that referenced this pull request Dec 18, 2015
provider/aws: EIP not noticing it has been unassigned from an ENI
@jen20 jen20 merged commit 30f9d61 into hashicorp:master Dec 18, 2015
@justnom
Copy link
Contributor Author

justnom commented Dec 18, 2015

No worries! There still seems to be some strange behaviour with the API for
associating an address that I am looking into, but this is a good start. :)

On Fri, 18 Dec 2015 17:33 James Nugent notifications@github.com wrote:

Merged #4387 #4387.


Reply to this email directly or view it on GitHub
#4387 (comment).

@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/aws: EIP not noticing it has been unassigned from an ENI
2 participants