Heroku Organization App Improvements #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,13 +9,24 @@ import ( | |||
| "github.com/hashicorp/terraform/helper/schema" | |||
| ) | |||
|
|
|||
| type herokuApplication struct { | |||
There was a problem hiding this comment.
Can we document what this is for?
application "is used to store all the details of a heroku app" but now it has a child App that is a herokuApplication ?
phinze
force-pushed
the
plan3-fixing_heroku_organization_app_read
branch
from
ad73258
to
45e29c3
Compare
phinze
force-pushed
the
plan3-fixing_heroku_organization_app_read
branch
from
45e29c3
to
7c055ed
Compare
|
Okay @catsby PTAL |
phinze
force-pushed
the
plan3-fixing_heroku_organization_app_read
branch
from
7c055ed
to
698dad9
Compare
… have it in a private area instead
Switching up ResourceData interaction to not reach into the internal dot-notation nesting.
phinze
force-pushed
the
plan3-fixing_heroku_organization_app_read
branch
from
698dad9
to
c527654
Compare
|
LGTM |
phinze
added a commit
that referenced
this pull request
Jan 6, 2016
…ion_app_read Heroku Organization App Improvements
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #668 with an acceptance test and updates to make it conform to modern standards.