Fixing heroku read for organization app

[kubek2k]

it will help in managing state when transitioning from org app to private and back.

[kubek2k]

I removed some unnecessary logic + added mandatory fields to be set about organization (locked, # and private)

[phinze]

Hi there - thanks for this!

Can you lay out for me some steps to take to smoke test this? Then I can verify it and pull it in if all looks good. 👍

[kubek2k]

this line could be dropped with recent fix for the map (count no longer stored)

[kubek2k]

the situation might occur eg:

• you have an existing private application in heroku with a name x
• you instruct terraform to create an organization application under the same name x
  terraform will conclude that the application already exists even though its in totally different namespace.

[phinze]

Working with Heroku Support to set up an organization for Terraform acceptance testing. Will follow up when I've heard back from them.

[josephholsten]

@phinze you heard back from heroku? anything we can do to move this forward?

[phinze]

I had a long and meandering support ticket that resulted in a test organization being allocated, but now logging into my account today it's gone again. 😞

Re-upped with a fresh support ticket and we'll see what happens.

If anybody from the community w/ an account can test this and report 👍 I'm happy to pull it in on your word. Otherwise I'll check back in when I get a fresh org acct.

[phinze]

Re-submitted this as #4495 - finally landing it! 😅

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.